-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding sensor interface and LM75 i2c sensor support #52
Conversation
Adding sensor interface and LM75 i2c sensor support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is really nice work, thanks!
I'm not in a position to test this out right now, so I take it it all works for you? Do you use the IO modules as well as the sensor ones?
Cheers,
Ellis
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Thanks for your review and the good comments.
I just tested the commented version on my raspberry with gpio modules only, sensor modules only and both gpio and sensor modules. It's just working fine. The version without your comments is running since 14 days in my home automation 24/7. |
From what I understand, and just to confirm, this doesn't break backwards compatibility with existing configurations, or add any dependencies does it? |
Thats correct. It still works fine with your original config.example.yml, that has no sensors configured. If someone notices a bug/defect, I'll fix it, of course. ;-) |
Sorry for the delay merging this. I'll make a note to do it this weekend. |
A new sensor interface is implemented, that reads sensors in the specified interval in a seperated thread. New sensors may easily be implemented by using the base class Sensor(GenericSensor) and implementing its methods. YAML config schema was extended for sensor interface. LM75 i2c temperatur sensor is implemented. This will be a basic step for #40.