Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sensor interface and LM75 i2c sensor support #52

Merged
merged 9 commits into from
Mar 10, 2019
Merged

Adding sensor interface and LM75 i2c sensor support #52

merged 9 commits into from
Mar 10, 2019

Conversation

BenjiU
Copy link
Collaborator

@BenjiU BenjiU commented Feb 18, 2019

A new sensor interface is implemented, that reads sensors in the specified interval in a seperated thread. New sensors may easily be implemented by using the base class Sensor(GenericSensor) and implementing its methods. YAML config schema was extended for sensor interface. LM75 i2c temperatur sensor is implemented. This will be a basic step for #40.

@BenjiU BenjiU mentioned this pull request Feb 18, 2019
Copy link
Owner

@flyte flyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really nice work, thanks!

I'm not in a position to test this out right now, so I take it it all works for you? Do you use the IO modules as well as the sensor ones?

Cheers,
Ellis

pi_mqtt_gpio/modules/lm75.py Outdated Show resolved Hide resolved
pi_mqtt_gpio/server.py Outdated Show resolved Hide resolved
pi_mqtt_gpio/server.py Outdated Show resolved Hide resolved
pi_mqtt_gpio/server.py Outdated Show resolved Hide resolved
pi_mqtt_gpio/server.py Outdated Show resolved Hide resolved
pi_mqtt_gpio/server.py Outdated Show resolved Hide resolved
flyte and others added 6 commits February 18, 2019 20:24
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
Co-Authored-By: BenjiU <46675043+BenjiU@users.noreply.github.com>
@BenjiU
Copy link
Collaborator Author

BenjiU commented Feb 18, 2019

Thanks for your review and the good comments.

I'm not in a position to test this out right now, so I take it it all works for you? Do you use the IO modules as well as the sensor ones?

I just tested the commented version on my raspberry with gpio modules only, sensor modules only and both gpio and sensor modules. It's just working fine. The version without your comments is running since 14 days in my home automation 24/7.

@flyte
Copy link
Owner

flyte commented Feb 19, 2019

From what I understand, and just to confirm, this doesn't break backwards compatibility with existing configurations, or add any dependencies does it?

@BenjiU
Copy link
Collaborator Author

BenjiU commented Feb 19, 2019

From what I understand, and just to confirm, this doesn't break backwards compatibility with existing configurations, or add any dependencies does it?

Thats correct. It still works fine with your original config.example.yml, that has no sensors configured. If someone notices a bug/defect, I'll fix it, of course. ;-)

@flyte
Copy link
Owner

flyte commented Mar 8, 2019

Sorry for the delay merging this. I'll make a note to do it this weekend.

@flyte flyte merged commit 026182c into flyte:develop Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants