-
Notifications
You must be signed in to change notification settings - Fork 551
/
node.go
166 lines (141 loc) · 5.82 KB
/
node.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
// This package contains validators for all elements of the workflow spec (node, task, branch, interface, bindings... etc.)
package validators
import (
"fmt"
"sort"
flyte "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core"
c "github.com/flyteorg/flyte/flytepropeller/pkg/compiler/common"
"github.com/flyteorg/flyte/flytepropeller/pkg/compiler/errors"
)
// Computes output parameters after applying all aliases -if any-.
func validateEffectiveOutputParameters(n c.NodeBuilder, errs errors.CompileErrors) (
params *flyte.VariableMap, ok bool) {
aliases := make(map[string]string, len(n.GetOutputAliases()))
for _, alias := range n.GetOutputAliases() {
if _, found := aliases[alias.Var]; found {
errs.Collect(errors.NewDuplicateAliasErr(n.GetId(), alias.Alias))
} else {
aliases[alias.Var] = alias.Alias
}
}
if n.GetInterface() != nil {
params = &flyte.VariableMap{
Variables: make(map[string]*flyte.Variable, len(n.GetInterface().GetOutputs().Variables)),
}
for paramName, param := range n.GetInterface().GetOutputs().Variables {
if alias, found := aliases[paramName]; found {
if newParam, paramOk := withVariableName(param); paramOk {
params.Variables[alias] = newParam
} else {
errs.Collect(errors.NewParameterNotBoundErr(n.GetId(), alias))
}
delete(aliases, paramName)
} else {
params.Variables[paramName] = param
}
}
// If there are still more aliases at this point, they point to non-existent variables.
for _, alias := range aliases {
errs.Collect(errors.NewParameterNotBoundErr(n.GetId(), alias))
}
}
return params, !errs.HasErrors()
}
func branchNodeIDFormatter(parentNodeID, thenNodeID string) string {
return fmt.Sprintf("%v-%v", parentNodeID, thenNodeID)
}
func ValidateBranchNode(w c.WorkflowBuilder, n c.NodeBuilder, requireParamType bool, errs errors.CompileErrors) (
discoveredNodes []c.NodeBuilder, ok bool) {
cases := make([]*flyte.IfBlock, 0, len(n.GetBranchNode().IfElse.Other)+1)
if n.GetBranchNode().IfElse.Case == nil {
errs.Collect(errors.NewBranchNodeHasNoCondition(n.GetId()))
} else {
cases = append(cases, n.GetBranchNode().IfElse.Case)
}
cases = append(cases, n.GetBranchNode().IfElse.Other...)
discoveredNodes = make([]c.NodeBuilder, 0, len(cases))
subNodes := make([]c.NodeBuilder, 0, len(cases)+1)
for _, block := range cases {
// Validate condition
ValidateBooleanExpression(w, n, block.Condition, requireParamType, errs.NewScope())
if block.GetThenNode() == nil {
errs.Collect(errors.NewBranchNodeNotSpecified(n.GetId()))
} else {
wrapperNode := w.GetOrCreateNodeBuilder(block.GetThenNode())
subNodes = append(subNodes, wrapperNode)
}
}
if elseNode := n.GetBranchNode().IfElse.GetElseNode(); elseNode != nil {
wrapperNode := w.GetOrCreateNodeBuilder(elseNode)
subNodes = append(subNodes, wrapperNode)
} else if defaultElse := n.GetBranchNode().IfElse.GetDefault(); defaultElse == nil {
errs.Collect(errors.NewBranchNodeHasNoDefault(n.GetId()))
}
for _, wrapperNode := range subNodes {
if ValidateNode(w, wrapperNode, requireParamType, errs.NewScope()) {
// Add to the global nodes to be able to reference it later
discoveredNodes = append(discoveredNodes, wrapperNode)
}
}
return discoveredNodes, !errs.HasErrors()
}
func validateNodeID(w c.WorkflowBuilder, nodeID string, errs errors.CompileErrors) (node c.NodeBuilder, ok bool) {
if nodeID == "" {
n, _ := w.GetNode(c.StartNodeID)
return n, !errs.HasErrors()
} else if node, ok = w.GetNode(nodeID); !ok {
errs.Collect(errors.NewNodeReferenceNotFoundErr(nodeID, nodeID))
}
return node, !errs.HasErrors()
}
func ValidateNode(w c.WorkflowBuilder, n c.NodeBuilder, validateConditionTypes bool, errs errors.CompileErrors) (ok bool) {
if n.GetId() == "" {
errs.Collect(errors.NewValueRequiredErr("<node>", "Id"))
}
if n.GetId() == c.StartNodeID || n.GetId() == c.EndNodeID {
return true
}
if _, ifaceOk := ValidateUnderlyingInterface(w, n, errs.NewScope()); ifaceOk {
// Validate node output aliases
validateEffectiveOutputParameters(n, errs.NewScope())
}
if n.GetCoreNode().UpstreamNodeIds == nil {
n.GetCoreNode().UpstreamNodeIds = make([]string, 0)
}
// Order upstream node ids to ensure consistent output of the compiler even if client ordering changes.
sort.Strings(n.GetCoreNode().UpstreamNodeIds)
// Validate branch node conditions and inner nodes.
if n.GetBranchNode() != nil {
if nodes, ok := ValidateBranchNode(w, n, validateConditionTypes, errs.NewScope()); ok {
for _, subNode := range nodes {
w.AddEdges(subNode, c.EdgeDirectionUpstream, errs.NewScope())
}
}
} else if workflowN := n.GetWorkflowNode(); workflowN != nil && workflowN.GetSubWorkflowRef() != nil {
workflowID := *workflowN.GetSubWorkflowRef()
// Only compile the subworkflow if it has not been error-free compiled before.
if _, wfOk := w.GetCompiledSubWorkflow(workflowID); !wfOk {
if wf, wfOk := w.GetSubWorkflow(workflowID); wfOk {
// This might lead to redundant errors if the same subWorkflow is invoked from multiple nodes in the main
// workflow.
if n.GetSubWorkflow() == nil {
if subWorkflow, workflowOk := w.ValidateWorkflow(wf, errs.NewScope()); workflowOk {
n.SetSubWorkflow(subWorkflow)
w.StoreCompiledSubWorkflow(workflowID, subWorkflow.GetCoreWorkflow())
}
}
} else {
errs.Collect(errors.NewWorkflowReferenceNotFoundErr(n.GetId(), workflowN.GetSubWorkflowRef().String()))
}
}
} else if taskN := n.GetTaskNode(); taskN != nil && taskN.GetReferenceId() != nil {
if task, found := w.GetTask(*taskN.GetReferenceId()); found {
n.SetTask(task)
} else if taskN.GetReferenceId() == nil {
errs.Collect(errors.NewValueRequiredErr(n.GetId(), "TaskNode.ReferenceId"))
} else {
errs.Collect(errors.NewTaskReferenceNotFoundErr(n.GetId(), taskN.GetReferenceId().String()))
}
}
return !errs.HasErrors()
}