[Housekeeping] mypy flytekit cleanup

[wild-endeavor]

Describe the Issue
Wholesale cleanup of mypy warnings and errors in flytekit. Larger items like tuple support should have standalone tickets created.

What if we do not do this?
Flytekit remains unpolished.

Related component
flytekit

[pingsutw]

There are too many errors, I broke out this task into more granular ones:

• [BUG] [flytekit] Support typing.Tuple for multiple returns #1029
• [BUG] [flytekit][mypy] Fix Incompatible types  #1427
• [BUG] [flytekit][mypy] Fix class name is not defined #1428
• [BUG] [flytekit][mypy] Fix item has no attribute error #1447

Feel free to add more details/edits to those as needed

[aeioulisa]

pls assign me I would like to work on this

[samhita-alla]

@wild-endeavor @pingsutw, has the issue been resolved?

[ryankarlos]

@samhita-alla is this issue still open - if so, I don;t mind fixing a few of these for hacktoberfest.

Also, i can see some issues #1427 #1447 related to this closed, with associate PR merged in.a year ago but i can still see some mypy errors related to Incompatible types - im presuming these are from more recent merges ? Please let me know if I have misunderstood.

$ make test | grep "Incompatible"
flytekit/core/tracker.py:232: error: Incompatible types in assignment (expression has type Module, variable has type "Union[Callable[..., Any], TrackedInstance]")
flytekit/core/tracker.py:234: error: Incompatible types in assignment (expression has type "Optional[Module]", variable has type Module)
flytekit/core/checkpointer.py:114: error: Incompatible types in assignment (expression has type "Path", variable has type "None")
flytekit/core/checkpointer.py:158: error: Incompatible types in assignment (expression has type "BufferedReader", variable has type "BytesIO")
flytekit/core/context_manager.py:95: error: Incompatible types in assignment (expression has type "Optional[datetime]", variable has type "datetime")
flytekit/core/context_manager.py:96: error: Incompatible types in assignment (expression has type "Optional[AutoDeletingTempDir]", variable has type "Union[PathLike[Any], AutoDeletingTempDir]")
flytekit/core/context_manager.py:98: error: Incompatible types in assignment (expression has type "Optional[Logger]", variable has type "Logger")
flytekit/core/context_manager.py:102: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str")
flytekit/core/type_engine.py:408: error: Incompatible return value type (got "List[Any]", expected "T")
flytekit/core/type_engine.py:411: error: Incompatible return value type (got "Dict[Any, Any]", expected "T")
flytekit/core/type_engine.py:1125: error: Incompatible return value type (got "object", expected "type")
flytekit/core/type_engine.py:1154: error: Incompatible return value type (got "Tuple[Any, ...]", expected "Tuple[Optional[type], Optional[type]]")
flytekit/core/type_engine.py:1228: error: Incompatible return value type (got "Type[Dict[Any, Any]]", expected "Type[T]")
flytekit/core/type_engine.py:1368: error: Incompatible return value type (got "object", expected "Type[T]")
flytekit/core/type_engine.py:1371: error: Incompatible return value type (got "Type[str]", expected "Type[T]")
flytekit/core/type_engine.py:1373: error: Incompatible return value type (got "Type[int]", expected "Type[T]")
flytekit/core/type_engine.py:1375: error: Incompatible return value type (got "Type[bool]", expected "Type[T]")
flytekit/core/type_engine.py:1378: error: Incompatible return value type (got "Type[int]", expected "Type[T]")
flytekit/core/type_engine.py:1380: error: Incompatible return value type (got "Type[float]", expected "Type[T]")
flytekit/core/type_engine.py:1381: error: Incompatible return value type (got "Type[str]", expected "Type[T]")
flytekit/core/interface.py:267: error: Incompatible return value type (got "object", expected "Type[T]")
flytekit/core/interface.py:270: error: Incompatible return value type (got "object", expected "Type[T]")
flytekit/core/interface.py:299: error: Incompatible types in assignment (expression has type "Parameter", variable has type "Type[Any]")
flytekit/core/promise.py:676: error: Incompatible return value type (got "Optional[NodeOutput]", expected "NodeOutput")
flytekit/core/base_task.py:281: error: Incompatible return value type (got "Union[Tuple[Promise], Promise, None]", expected "Union[Tuple[Promise], Promise, VoidPromise]")
flytekit/core/python_customized_container_task.py:108: error: Incompatible types in assignment (expression has type "Optional[Dict[str, str]]", variable has type "Dict[str, str]")
flytekit/types/file/file.py:30: error: Incompatible types in assignment (expression has type "None", variable has type "Union[str, PathLike[Any]]")
flytekit/types/file/file.py:209: error: Incompatible return value type (got "Optional[PathLike[Any]]", expected "PathLike[Any]")
flytekit/types/directory/types.py:29: error: Incompatible types in assignment (expression has type "None", variable has type "Unio

[pingsutw]

Thank you @ryankarlos, we still have some linting errors which aren't fixed yet. Feel free to open a pr in the flytekit repo 😄

[ryankarlos]

Thanks @pingsutw , ive run make lint in the flytekit repo - im assuming i can attempt to fix any of these or do you want to focus on AttributeError, Class name not defined etc following on from the previous closed issues linked in this issue ?
Also, ok if i split these between multiple PRs ?

[pingsutw]

yeah, I prefer to split these between multiple PRs, which will be easy to review.

[ryankarlos]

thanks im working on a PR. do you labelling this issue with hacktoberfest label 😄 @samhita-alla

[samhita-alla]

@pingsutw, is it okay to close this PR or are there any more fixes that need to go in?

[pingsutw]

Still have some mypy errors needed to be fixed. @ryankarlos is working on it.

[ryankarlos]

@pingsutw I may not get around to fixing the others immediately - as got a few other PRs to complete as well. Feel free to unassign me if someone else wants to tackle some of the remaining.