Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in a k8s cluster with mutating webhooks, tasks don't finish since the side car is still working [Core Feature] #1564

Open
NotMatthewGriffin opened this issue Oct 5, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@NotMatthewGriffin
Copy link

Motivation: Why do you think this is important?
Currently when running a flyte task in a kubernetes cluster that uses mutating webhooks to add sidecars to all pods, the task and associated pod will run until terminated in the flyte web console. Inside of the pod, the container actually running the flyte task has completed and exited with a good status but the sidecar container is still running. To work around this a user must specify the task in their workflow as a pod task like @task(task_config=Pod(pod_spec=pod_spec, pimary_container_name="container_name")). This means that users need to know the configuration of the cluster ( like will any sidecars be added automatically) in order to successfully create/run a flyte workflow.

Goal: What should the final outcome look like, ideally?
Ideally a user of flyte wouldn't need to declare their task as a pod task in order to run it in a kubernetes cluster that uses mutating webhooks to add sidecars to pods. The user could declare their task like @task and it would run the flyte task pod until the flyte task container finishes then the rest of the workflow would be run.

Describe alternatives you've considered
The only other alternative I've considered is continuing to use the workaround of declaring all workflows/tasks as pod tasks.

@NotMatthewGriffin NotMatthewGriffin added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 5, 2021
@welcome
Copy link

welcome bot commented Oct 5, 2021

Thank you for opening your first issue here! 🛠

@kumare3
Copy link
Contributor

kumare3 commented Oct 6, 2021

@NotMatthewGriffin thank you for the issue. I have heard from a few users about this issue. The only problem is there are a few folks that run @task on a non k8s cluster and the container abstraction keeps it simple. But, it is completely possible to ensure that on K8s we can assert that the main container exit is the only signal that is needed to mark completion.

How urgent do you think this work is?

@kumare3
Copy link
Contributor

kumare3 commented Oct 7, 2021

can we slot this for november?

@NotMatthewGriffin
Copy link
Author

@kumare3 I don't think this issue is show stopping for anyone since we know of the workaround. Mostly its just a little inconvenient to require extra configuration for running in some k8s clusters and not others.

I would be happy if this was addressed in November :)

If this is something I could help address I would also be happy to help.

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Oct 7, 2021
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants