Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Support passing auth cookie settings in admin #2596

Closed
2 tasks done
pmahindrakar-oss opened this issue Jun 7, 2022 · 0 comments · Fixed by flyteorg/flyteadmin#440
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@pmahindrakar-oss
Copy link
Contributor

Motivation: Why do you think this is important?

Cookie settings allow to configure how the auth cookies will be used in different domain settings.
Two settings to start off with that we should add are.

  • DomainMatchPolicy
    Allow subdomain access to the created cookies by setting the domain attribute or do an exact match on domain.
  • SameSitePolicy
    Allows you to declare if your cookie should be restricted to a first-party or same-site context.Wrapper around http.SameSite.

Goal: What should the final outcome look like, ideally?

Cookie settings configurable for admin auth

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jun 7, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.2 milestone Jun 7, 2022
@pmahindrakar-oss pmahindrakar-oss self-assigned this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant