Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch flyteidl output to be commonjs #27

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Switch flyteidl output to be commonjs #27

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Labels
ui Admin console user interface

Comments

@georgesnelling
Copy link
Contributor

flyteidl is currently being output as an es6 module, which makes it incompatible with NodeJS unless it is run through webpack first. There's no real reason to do it that way, and protobufjs supports commonjs output, so we should switch to that.
@schottra schottra added ui Admin console user interface and removed pri3 labels Jul 6, 2020
@schottra schottra removed their assignment Jul 6, 2020
@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Bug bankruptcy.

@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
Generic type support in Workflow compiler (flyteorg#27)
9d0117e 
Generic input types were not supported in compiler. This PR introduces support. At runtime as generic is any other scalar type, was working fine
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@tnsetting
Support postgres extra options [gcp] (flyteorg#27)
ae314d1 
* Support postgres extra options [gcp]

Right now it is enforced to use sslmode when flyte admin is connecting to postgres and password provided.
The PR make it possible to connect to postgres when disabling sslmode.

* Add test

* Add test for case with pwd but no extra option
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@honnix @wild-endeavor @EngHabu
migrate to go module (flyteorg#27)
e6e8040 
* migrate to go module

* install mockery

* do not always download pflags

* latest version of flytestdlib

* refomat

* Revert "refomat"

This reverts commit 106ee8e73e2c0af5797ba78034014bd1183bafca.

* mockery

* mockery

* sum

* test

* test

* test

* test

* test

* Update .travis.yml

* Update Makefile

* Update Makefile

* move it to the right place

* install mockery in a temp folder

* add comments

* upgrade flytestdlib

* go mod tidy

* add h1 sum

* test

* rebase from master

* latest flytestdlib

* install pflags in tmp folder

* change go version back

* add comment

* incorporate latest boilerplate changes

* rely on Makefile to install mockery

* updated boilerplate

* use install instead

* actually adding the new boilerplate entry and updating again

* removing unnecessary files

* no need for replacement in root go.mod

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@chanadian
Preserve partition order when returning (flyteorg#27)
58a33f5
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
Update Boilerplate (flyteorg#27)
87c187b 
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
Generic type support in Workflow compiler (flyteorg#27)
5bc6443 
Generic input types were not supported in compiler. This PR introduces support. At runtime as generic is any other scalar type, was working fine
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@tnsetting
Support postgres extra options [gcp] (flyteorg#27)
ec40b1d 
* Support postgres extra options [gcp]

Right now it is enforced to use sslmode when flyte admin is connecting to postgres and password provided.
The PR make it possible to connect to postgres when disabling sslmode.

* Add test

* Add test for case with pwd but no extra option
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@chanadian
Preserve partition order when returning (flyteorg#27)
66e152c
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@flyte-bot
Update Boilerplate (flyteorg#27)
b7b585d 
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pmahindrakar-oss
Added protoc-gen-doc dependency for IDL doc generation (flyteorg#27)
a5a04fc 
* Added protoc-gen-doc dependency for IDL doc generation

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Formatting change

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@honnix @wild-endeavor @EngHabu
migrate to go module (#27)
ce2f851 
* migrate to go module

* install mockery

* do not always download pflags

* latest version of flytestdlib

* refomat

* Revert "refomat"

This reverts commit b30109297ce71b8f40e9cfab60b2db9d1dd8ad06.

* mockery

* mockery

* sum

* test

* test

* test

* test

* test

* Update .travis.yml

* Update Makefile

* Update Makefile

* move it to the right place

* install mockery in a temp folder

* add comments

* upgrade flytestdlib

* go mod tidy

* add h1 sum

* test

* rebase from master

* latest flytestdlib

* install pflags in tmp folder

* change go version back

* add comment

* incorporate latest boilerplate changes

* rely on Makefile to install mockery

* updated boilerplate

* use install instead

* actually adding the new boilerplate entry and updating again

* removing unnecessary files

* no need for replacement in root go.mod

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@honnix @wild-endeavor @eapolinario
migrate to go module (#27)
34884d8 
* migrate to go module

* install mockery

* do not always download pflags

* latest version of flytestdlib

* refomat

* Revert "refomat"

This reverts commit b30109297ce71b8f40e9cfab60b2db9d1dd8ad06.

* mockery

* mockery

* sum

* test

* test

* test

* test

* test

* Update .travis.yml

* Update Makefile

* Update Makefile

* move it to the right place

* install mockery in a temp folder

* add comments

* upgrade flytestdlib

* go mod tidy

* add h1 sum

* test

* rebase from master

* latest flytestdlib

* install pflags in tmp folder

* change go version back

* add comment

* incorporate latest boilerplate changes

* rely on Makefile to install mockery

* updated boilerplate

* use install instead

* actually adding the new boilerplate entry and updating again

* removing unnecessary files

* no need for replacement in root go.mod

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Sep 26, 2023
@chanadian
Preserve partition order when returning (flyteorg#27)
c38a569
pvditt pushed a commit that referenced this issue Dec 29, 2023
@honnix @wild-endeavor @EngHabu
migrate to go module (#27)
0c33bc4 
* migrate to go module

* install mockery

* do not always download pflags

* latest version of flytestdlib

* refomat

* Revert "refomat"

This reverts commit 106ee8e73e2c0af5797ba78034014bd1183bafca.

* mockery

* mockery

* sum

* test

* test

* test

* test

* test

* Update .travis.yml

* Update Makefile

* Update Makefile

* move it to the right place

* install mockery in a temp folder

* add comments

* upgrade flytestdlib

* go mod tidy

* add h1 sum

* test

* rebase from master

* latest flytestdlib

* install pflags in tmp folder

* change go version back

* add comment

* incorporate latest boilerplate changes

* rely on Makefile to install mockery

* updated boilerplate

* use install instead

* actually adding the new boilerplate entry and updating again

* removing unnecessary files

* no need for replacement in root go.mod

Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Feature/goreleaser (flyteorg#27)
6fee6ad
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
Feature/goreleaser (flyteorg#27)
22c203b
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
Feature/goreleaser (flyteorg#27)
fb66e97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui Admin console user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EngHabu @georgesnelling @schottra