Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Decorate manually deleted k8s resources with error message #2843

Open
2 tasks done
Tracked by #2917
hamersaw opened this issue Sep 2, 2022 · 2 comments
Open
2 tasks done
Tracked by #2917
Labels
enhancement New feature or request good first issue Good for newcomers plugins Plugins related labels (backend or frontend) propeller Issues related to flyte propeller stale

Comments

@hamersaw
Copy link
Contributor

hamersaw commented Sep 2, 2022

Motivation: Why do you think this is important?

Flyte Pods (or other k8s resources depending on the plugin) may be delete by an external process in the background. Flyte can detect this in two scenarios (1) the k8s object is missing or (2) the k8s object is marked as "deleted". In the latter case we should attempt to decorate the Flyte error message with the cause of deletion. In Pods there is are reason and message fields which should contain more precise information. This would help users debug these cases.

Goal: What should the final outcome look like, ideally?

When detecting externally deleted k8s resources Flyte should do it's best to decorate the error message with the cause for deletion.

Describe alternatives you've considered

Leaving it as is, with no additional context.

Propose: Link/Inline OR Additional context

The deletion timestamp is handled in FlytePropeller and FlytePlugins k8s array tasks separately. A fix would be to "best effort" parse the object and decorate the error with a more actionable message.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added enhancement New feature or request good first issue Good for newcomers untriaged This issues has not yet been looked at by the Maintainers labels Sep 2, 2022
@hamersaw hamersaw added propeller Issues related to flyte propeller plugins Plugins related labels (backend or frontend) and removed untriaged This issues has not yet been looked at by the Maintainers labels Sep 2, 2022
@hamersaw hamersaw added this to the 1.3.0-candidate milestone Sep 2, 2022
@hamersaw hamersaw changed the title [Core feature] Decorate manually delete k8s resources with error message [Core feature] Decorate manually deleted k8s resources with error message Sep 7, 2022
@div-devs
Copy link

div-devs commented Oct 4, 2022

can you assign this to me please

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers plugins Plugins related labels (backend or frontend) propeller Issues related to flyte propeller stale
Projects
None yet
Development

No branches or pull requests

4 participants