Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Set FlytePropeller node and workflow deadlines to infinite #2950

Closed
2 tasks done
Tracked by #2917
hamersaw opened this issue Oct 4, 2022 · 2 comments · Fixed by flyteorg/flytepropeller#493
Closed
2 tasks done
Tracked by #2917
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest propeller Issues related to flyte propeller
Milestone

Comments

@hamersaw
Copy link
Contributor

hamersaw commented Oct 4, 2022

Motivation: Why do you think this is important?

FlytePropeller uses a few configuration values, namely node-execution-deadline, node-active-deadline, and workflow-active-deadline to restrict the runtimes of workflows and nodes. These configuration are applied during long-running node and workflow executions. Currently, the defaults are 48h for node deadlines and 72h for workflow deadlines. The issue is that users with long-running tasks / workflow experience unintended terminations under the default configuration.

Goal: What should the final outcome look like, ideally?

These deadline configuration values should be set to 0 by default, effectively disabling them and setting the deadlines to infinity. Therefore, users with long-running tasks/workflows will not experience unintended terminations.

Describe alternatives you've considered

Leaving it as is provides some level of sane configuration, but results in unintended termination for some users.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added enhancement New feature or request good first issue Good for newcomers propeller Issues related to flyte propeller labels Oct 4, 2022
@hamersaw hamersaw added this to the 1.3.0 milestone Oct 4, 2022
@AyushK-101
Copy link

I would like to work on this

@Ln11211
Copy link
Contributor

Ln11211 commented Oct 11, 2022

@hamersaw I opened a PR , could you please review it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest propeller Issues related to flyte propeller
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants