Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 1.3.0 broke task execution #3261

Closed
2 tasks done
honnix opened this issue Jan 24, 2023 · 3 comments · Fixed by flyteorg/flytekit#1422
Closed
2 tasks done

[BUG] 1.3.0 broke task execution #3261

honnix opened this issue Jan 24, 2023 · 3 comments · Fixed by flyteorg/flytekit#1422
Labels
bug Something isn't working

Comments

@honnix
Copy link
Contributor

honnix commented Jan 24, 2023

Describe the bug

After upgraded to 1.3.0, remote.execute stopped working with exception:

...
                # We need to manually make a map of the nodes since there is none for single task executions
                # Assume the first one is the only one.
                node_mapping = (
                    {
>                       task_node_exec[0].id.node_id: FlyteNode(
                            id=flyte_entity.id,
                            upstream_nodes=[],
                            bindings=[],
                            metadata=NodeMetadata(name=""),
                            flyte_task=flyte_entity,
                        )
                    }
                    if len(task_node_exec) >= 1
                    else {}  # This is for the case where node executions haven't appeared yet
                )
E               TypeError: __init__() got an unexpected keyword argument 'flyte_task'
.tox/py38-test/lib/python3.8/site-packages/flytekit/remote/remote.py:1454: TypeError

As commented in flyteorg/flytekit#1348 (comment), it seems to be that PR breaking it during refactoring.

Expected behavior

remote.execute should work

Additional context to reproduce

  • Upgrade to 1.3.0
  • Do the following
execution = remote.execute(
        ...
    )

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@honnix honnix added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jan 24, 2023
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Jan 24, 2023
@kumare3
Copy link
Contributor

kumare3 commented Jan 24, 2023

this sounds, odd, pyflyte run uses this same code path. Checking!

@kumare3
Copy link
Contributor

kumare3 commented Jan 24, 2023

ohh i see it, its in sync execution. so the wait is broken?

@wild-endeavor
Copy link
Contributor

flyteorg/flytekit#1422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants