Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Use mashumaro to serialize/deserialize dataclass #3364

Closed
2 tasks done
pingsutw opened this issue Feb 22, 2023 · 2 comments
Closed
2 tasks done

[Core feature] Use mashumaro to serialize/deserialize dataclass #3364

pingsutw opened this issue Feb 22, 2023 · 2 comments
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers
Milestone

Comments

@pingsutw
Copy link
Member

Motivation: Why do you think this is important?

mashumaro has better performance than marshmallow we use now. we should be able to replace it with marshmallow in flytekit.

image

Goal: What should the final outcome look like, ideally?

  1. Reduce overhead while serialize/deserialize dataclass.
  2. Should not break existing users

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added enhancement New feature or request good first issue Good for newcomers flytekit FlyteKit Python related issue labels Feb 22, 2023
@hajapy
Copy link

hajapy commented Feb 25, 2023

Another bonus beside speed is it should eliminate the many marshmallow deprecation warnings we see with the current ser/de for dataclasses.

@hhcs9527
Copy link

Hi @eapolinario @pingsutw please check PR for this issue.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit FlyteKit Python related issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants