Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ARM64 Docker Images contains x86_64 binaries (helm) #3423

Closed
2 tasks done
qbx2 opened this issue Mar 8, 2023 · 5 comments
Closed
2 tasks done

[BUG] ARM64 Docker Images contains x86_64 binaries (helm) #3423

qbx2 opened this issue Mar 8, 2023 · 5 comments
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@qbx2
Copy link

qbx2 commented Mar 8, 2023

Describe the bug

I am not able to run the arm64 docker images on aws graviton instances because arm64 docker images are built in incorrect way.

To check:

$ docker run -it --platform linux/arm64 -u root cr.flyte.org/flyteorg/flyteadmin-release:latest sh

/ # apk add file

/ # file bin/flyteadmin
bin/flyteadmin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=pwwxVfCtJjTsZm9XA0ED/BJdCEuBm0QjhMujOZ7E7/a_vHl8mBZ4xrHPFYqAdf/on6kzeFZfsYdRjhPjzhK, stripped

Other images also have this issue, for example:

$ docker run -it --platform linux/arm64 -u root cr.flyte.org/flyteorg/datacatalog:latest sh

/ # apk add file

/ # file bin/datacatalog
bin/datacatalog: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=YBzDJD8nguzh9dRW4GPp/iKNJqrMQzbqKL7lVR_L0/_wLIwVTI2EO3sXJO2Sup/5m-2xGfqxh4rTZlXehX4, not stripped

I did not check every images, but I'm pretty sure that most images have the issue.

Expected behavior

ARM64 Docker Images should not contain x86_64 binaries. They should contain arm64 binaries instead. Graviton instances should be able to run flyte using docker.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@qbx2 qbx2 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 8, 2023
@welcome
Copy link

welcome bot commented Mar 8, 2023

Thank you for opening your first issue here! 🛠

@qbx2 qbx2 changed the title [BUG] ARM64 Docker Images contains x86_64 binaries [BUG] ARM64 Docker Images contains x86_64 binaries (flyte-core) Mar 8, 2023
@qbx2 qbx2 changed the title [BUG] ARM64 Docker Images contains x86_64 binaries (flyte-core) [BUG] ARM64 Docker Images contains x86_64 binaries (helm) Mar 8, 2023
@jeevb
Copy link
Contributor

jeevb commented Mar 15, 2023

This has to do with the make linux-compile target. It doesn’t respect the env vars set in the Dockerfile.

@eapolinario
Copy link
Contributor

@qbx2
Copy link
Author

qbx2 commented Apr 20, 2023

@eapolinario Thank you for the fix, could you please tell when is the fix going to be released?

@eapolinario
Copy link
Contributor

@qbx2 , we have a monthly release cadence (unless we have a high pri / security issue). The current expectation is to have 1.6 out by the beginning of May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

3 participants