Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Add CI tests to flytekit repo: plugins should be importable with flytekit dependencies only #4619

Open
2 tasks done
cosmicBboy opened this issue Dec 18, 2023 · 1 comment
Labels
flytekit FlyteKit Python related issue housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@cosmicBboy
Copy link
Contributor

Describe the issue

The purpose of this issue is to enforce the following convention in flytekitplugins: "I should be able to import flytekitplugins.<plugin> with only flytekit dependencies. This ensures that we use lazy module loading in the plugins (see flyteorg/flytekit#2049).

What if we do not do this?

When new plugins are introduced (or existing ones are extended) contributions can break this convention when new dependencies are added.

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Dec 18, 2023
Copy link

dosubot bot commented Dec 18, 2023

🤖

That sounds like a great idea! Enforcing this convention will definitely help maintain consistency and prevent unexpected issues with new plugin contributions. Your proposed solution will be a valuable addition to the flytekit repo. Thank you for considering this improvement!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@eapolinario eapolinario added the flytekit FlyteKit Python related issue label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flytekit FlyteKit Python related issue housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

2 participants