Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

500 returned when querying outputs for a custom container #49

Closed
georgesnelling opened this issue Nov 19, 2019 · 2 comments
Closed

500 returned when querying outputs for a custom container #49

georgesnelling opened this issue Nov 19, 2019 · 2 comments
Assignees
@matthewphsmith
Labels
bug Something isn't working pri2

Comments

@georgesnelling
Copy link
Contributor

There is an expectation from Admin that some type of output will exist in storage for a NodeExecution. This turns out not to be the case if a container is running without the SDK. We need some type of handling for this case.
@georgesnelling georgesnelling added bug Something isn't working pri2 Trust labels Nov 19, 2019
@kumare3
Copy link
Contributor

kumare3 commented Apr 25, 2020

I do not think this is valid or true any more. Should we resolve this? @matthewphsmith

@kumare3
Copy link
Contributor

kumare3 commented Jun 10, 2020

Closing this issue

@kumare3 kumare3 closed this as completed Jun 10, 2020
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@EngHabu
Statemachine & Status fixes (Discretization, status size... etc.) (fl…
a79c03f 
…yteorg#49)

This PR fixes a few issues uncovered during the investigation of the statemachine inconsistency issues last week. Specifically:

- [X] Ensure each node can a progress at most once per round (IsDirty flag)
- [X] Remove ParentTaskID and DataDir from NodeStatus field (Causing workflow etcd. obj size to bloat)
- [X] Add Parent RetryAttempt in the generated hierarchal name of dynamic sub-nodes to ensure retries do not reuse an existing sub-node status.

Details: https://docs.google.com/document/d/1ISaxIZeYLcBaeapEmeTqb-g0x04pJbf5t3i30qMfk6U/edit?usp=sharing
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@katrogan
Consolidate and reorganize project, domain & workflow resource matchi…
e0ac32e 
…ng (flyteorg#49)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@wild-endeavor
Add GitHub workflow python publishing (flyteorg#49)
0d232a7
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Ignore codecoverage files from git (flyteorg#49)
f921467
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@bnsblue
Merge pull request flyteorg#49 from lyft/trace-token-ages
e5ab731 
Emit request wait time (duration) as a metric
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@veggiemonk @EngHabu
Update boilerplate (flyteorg#49)
0562e38 
Signed-off-by: Julien Bisconti <veggiemonk@users.noreply.github.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pmahindrakar-oss @EngHabu
Oauth support in flytectl (flyteorg#49)
cf63c5c 
* Using changed flyteidl which contains oauth changes

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added zlando keyring as an implementation of tokencache

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed unit tests

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed linter issues

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* go mod tidy

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to latest flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to released flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@EngHabu
Statemachine & Status fixes (Discretization, status size... etc.) (fl…
3574a4d 
…yteorg#49)

This PR fixes a few issues uncovered during the investigation of the statemachine inconsistency issues last week. Specifically:

- [X] Ensure each node can a progress at most once per round (IsDirty flag)
- [X] Remove ParentTaskID and DataDir from NodeStatus field (Causing workflow etcd. obj size to bloat)
- [X] Add Parent RetryAttempt in the generated hierarchal name of dynamic sub-nodes to ensure retries do not reuse an existing sub-node status.

Details: https://docs.google.com/document/d/1ISaxIZeYLcBaeapEmeTqb-g0x04pJbf5t3i30qMfk6U/edit?usp=sharing
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Ignore codecoverage files from git (flyteorg#49)
b957e07
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@katrogan
Consolidate and reorganize project, domain & workflow resource matchi…
ad65c85 
…ng (flyteorg#49)
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@bnsblue
Merge pull request flyteorg#49 from lyft/trace-token-ages
b5a3ed4 
Emit request wait time (duration) as a metric
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@veggiemonk @EngHabu
Update boilerplate (flyteorg#49)
2bbb8f5 
Signed-off-by: Julien Bisconti <veggiemonk@users.noreply.github.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@yindia
revert go version in support tools (flyteorg#49)
5dedb5b 
* revert go version in support tools

Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit that referenced this issue Sep 7, 2023
@veggiemonk @EngHabu
Update boilerplate (#49)
ec4b30e 
Signed-off-by: Julien Bisconti <veggiemonk@users.noreply.github.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@wild-endeavor
Add GitHub workflow python publishing (#49)
0ddbd1c
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@yindia
Fixed docker build for fork repository (#49)
8c8d13f 
Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@wild-endeavor @eapolinario
Add GitHub workflow python publishing (#49)
7cb38a3 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pvditt pushed a commit that referenced this issue Dec 29, 2023
@wild-endeavor
Add GitHub workflow python publishing (#49)
cd4943f
pmahindrakar-oss pushed a commit that referenced this issue Feb 5, 2024
@katrogan
Add org-aware error messaging for project validation (#49)
aaade8d
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@pmahindrakar-oss @EngHabu
Oauth support in flytectl (flyteorg#49)
f103e41 
* Using changed flyteidl which contains oauth changes

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added zlando keyring as an implementation of tokencache

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed unit tests

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed linter issues

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* go mod tidy

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to latest flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to released flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@pmahindrakar-oss @EngHabu @austin362667
Oauth support in flytectl (flyteorg#49)
3ea409b 
* Using changed flyteidl which contains oauth changes

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Added zlando keyring as an implementation of tokencache

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed unit tests

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Fixed linter issues

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* go mod tidy

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to latest flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

* Update to released flyteidl

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>

Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewphsmith matthewphsmith

Labels
bug Something isn't working pri2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgesnelling @matthewphsmith @kumare3