Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Flyteadmin SMPT email publisher #5390

Open
2 tasks done
Future-Outlier opened this issue May 19, 2024 · 1 comment
Open
2 tasks done

[Core feature] Flyteadmin SMPT email publisher #5390

Future-Outlier opened this issue May 19, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Future-Outlier
Copy link
Member

Future-Outlier commented May 19, 2024

Motivation: Why do you think this is important?

When attending the community sync, engineers from Spotify mentioned that they want to save costs when sending emails, and that most big tech companies use the SMTP layer for their mail servers.

If we support an SMTP email publisher, we can help save a lot of money compared to using services like SendGrid, AWS, and GCP.

Goal: What should the final outcome look like, ideally?

We should support config like this.

notifications:
  type: SMTP
  emailer:
    emailServerConfig:
      apiKeyEnvVar: "SENDGRID_API_KEY"
    subject: "Notice: Execution \"{{ name }}\" has {{ phase }} in \"{{ domain }}\"."
    sender: "example@spotifiy.com"  # Consider using a generic email instead of personal
    body: >
      Execution \"{{ name }}\" has {{ phase }} in \"{{ domain }}\". View details at
      <a href=\http://example.com/projects/{{ project }}/domains/{{ domain }}/executions/{{ name }}>
      http://example.com/projects/{{ project }}/domains/{{ domain }}/executions/{{ name }}</a>. {{ error }}

Describe alternatives you've considered

We can definitely support, so there's no alternative.

Propose: Link/Inline OR Additional context

We can use docker-mail server to build a mail server with SMTP protocol locally, and try to implement it like sandbox email publisher.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Future-Outlier Future-Outlier added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 19, 2024
@Future-Outlier Future-Outlier self-assigned this May 19, 2024
@Future-Outlier
Copy link
Member Author

Reply from Ketan:
The problem is potential spam classification.
We need to notify users to configure their mail server to avoid spam classification from SMTP provider.

@Future-Outlier Future-Outlier removed their assignment May 21, 2024
@eapolinario eapolinario added help wanted Extra attention is needed and removed untriaged This issues has not yet been looked at by the Maintainers labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants