Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Set external storage flag on wipe #623

Merged
merged 2 commits into from Nov 14, 2018
Merged

Set external storage flag on wipe #623

merged 2 commits into from Nov 14, 2018

Conversation

abma
Copy link
Contributor

@abma abma commented Nov 13, 2018

Changes description

Set WIPE_EXTERNAL_STORAGE flag on wipe & keep needed UserToken

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

Estimated time

Assignee 🍅
@btry 1
@ajsb85 1

References

Closes #607 #621
Related #622
Depends on #N/A

@ghost
Copy link

ghost commented Nov 13, 2018

There were the following issues with this Pull Request

  • Commit: d7c664f
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: afa947b
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@abma
Copy link
Contributor Author

abma commented Nov 13, 2018

wrt the automatic tests failing: i have no clue how to fix them.

@ajsb85 ajsb85 requested review from ajsb85, btry and a team and removed request for ajsb85 and btry November 14, 2018 00:33
@ajsb85 ajsb85 added the feature label Nov 14, 2018
@ajsb85 ajsb85 added this to the 2.0 milestone Nov 14, 2018
@ajsb85 ajsb85 added this to To Do in MDM Agent via automation Nov 14, 2018
@ajsb85 ajsb85 changed the title set WIPE_EXTERNAL_STORAGE flag on wipe & keep needed UserToken Set external storage flag on wipe Nov 14, 2018
Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes

Copy link
Contributor

@ajsb85 ajsb85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No conventional commit messages. But I can squash it.
Thanks for your contribution.

@ajsb85 ajsb85 merged commit b15e0cf into flyve-mdm:develop Nov 14, 2018
MDM Agent automation moved this from To Do to Done Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
MDM Agent
  
Done
3 participants