Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven warning when using Flyway plugin with parallel builds #1305

Closed
cowwoc opened this issue May 6, 2016 · 2 comments
Closed

Maven warning when using Flyway plugin with parallel builds #1305

cowwoc opened this issue May 6, 2016 · 2 comments

Comments

@cowwoc
Copy link

@cowwoc cowwoc commented May 6, 2016

What version of Flyway are you using?

4.0

What database are you using (type & version)?

Doesn't matter

What operating system are you using?

Windows 7

What did you do?

(Please include the content causing the issue, any relevant configuration settings, and the command you ran)

            <plugin>
                <groupId>org.flywaydb</groupId>
                <artifactId>flyway-maven-plugin</artifactId>
                <version>4.0</version>
                <executions>
                    <execution>
                        <id>migrate-db</id>
                        <goals>
                            <goal>migrate</goal>
                        </goals>
                        <phase>generate-sources</phase>
                    </execution>
                </executions>
                <dependencies>
                    <dependency>
                        <groupId>mysql</groupId>
                        <artifactId>mysql-connector-java</artifactId>
                        <version>${mysql.version}</version>
                    </dependency>
                </dependencies>
            </plugin>

Invoked "mvn clean install -T 8" to trigger parallel builds.

What did you expect to see?

According to https://flywaydb.org/documentation/faq#parallel Flyway supports parallel migrations, so I am not expecting to see any warnings.

What did you see instead?
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that are not marked as       *
[WARNING] * @threadSafe to support parallel building.                     *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in data-access:
[WARNING] org.flywaydb:flyway-maven-plugin:4.0
[WARNING] *****************************************************************
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented May 7, 2016

The word parallel in this FAQ entry referred to clusters of machines and not Maven builds.

However I agree that having the ability to use Maven's parallel builds is a valuable feature.

@axelfontaine axelfontaine added this to the Flyway 4.1 milestone May 7, 2016
@axelfontaine axelfontaine modified the milestones: Flyway 5.0, Flyway 4.1 Feb 6, 2017
davidkarlsen added a commit to davidkarlsen/flyway that referenced this issue May 29, 2017
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Nov 27, 2017
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 27, 2017

This has been fixed as part of the Maven 3.0 conversion of the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants