Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateOnMigrate is true by default #695

Closed
vertex-github opened this issue Feb 10, 2014 · 4 comments
Closed

validateOnMigrate is true by default #695

vertex-github opened this issue Feb 10, 2014 · 4 comments
Milestone

Comments

@vertex-github
Copy link

@vertex-github vertex-github commented Feb 10, 2014

We just had a case where additional SQL was added to an already applied SQL change file. On databases that already had the SQL change file applied, Flyway ignored the new additions since as far as it was concerned, the changeset had been applied. However, this led to problems since developers working off fresh DB copies got the new changeset (as did all unit tests that leverage in-memory DBs like H2), pushed changes to prod, and ended up with an inconsistent DB.

Could Flyway also check that the provided SQL files had not been modified since they were applied, and if so report an error (fail fast, rather than ignore the changeset) if this is the case?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 11, 2014

Set validateOnMigrate to true and you should be good to go.

I'll look into improving the documentation for this on the website.

@vertex-github
Copy link
Author

@vertex-github vertex-github commented Feb 11, 2014

Awesome! Many thanks.

In the spirit of fail-fast, is there a reason that this property isnt set by default?

Nick

On Tue, Feb 11, 2014 at 11:40 AM, Axel Fontaine notifications@github.comwrote:

Set validateOnMigrate to true and you should be good to go.

I'll look into improving the documentation for this on the website.

Reply to this email directly or view it on GitHubhttps://github.com//issues/695#issuecomment-34773078
.

@axelfontaine axelfontaine added this to the Flyway 3.0 milestone Apr 15, 2014
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Apr 19, 2014

As of Flyway 3.0, validateOnMigrate is now true by default.

axelfontaine added a commit that referenced this issue Apr 19, 2014
@axelfontaine axelfontaine changed the title Provide checksum / file length check on SQL files validateOnMigrate is true by default Apr 19, 2014
@mosingh123
Copy link

@mosingh123 mosingh123 commented Jan 10, 2015

where to set the property false please explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants