Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to run migrations in transactions on databases that do not support transactional ddl #1071

Closed
wants to merge 1 commit into from
Closed

Do not try to run migrations in transactions on databases that do not support transactional ddl #1071

wants to merge 1 commit into from

Conversation

Nthalk
Copy link

@Nthalk Nthalk commented Aug 2, 2015

Previously, in ticket #655, PostgresSQL was given special java api support to do things like vacuum that do not play nicely within transactions.

I currently have a script that renames a lot of constraints in Oracle, and apparently, there is some hidden limit to that within a transaction that causes the script to fault, yet run fine without a wrapping transaction.

However, #655 introduced supportsDdlTransactions, a good hint that perhaps, for migrating, we should not use a transaction, since an error will mean that we will most likely end up in an inconsistent state, and need other tools for rollbacks (I've been using vagrant && vagrant-snapshot).

@axelfontaine
Copy link
Contributor

Interesting idea. It is not without its downsides as migrations updating reference now also lose all rollbacks abilities.

Just to be sure: have you upgraded to the very latest Oracle version and verified it occurs there too?

@Nthalk
Copy link
Author

Nthalk commented Oct 7, 2015

@axelfontaine Yes, but if the database doesn't supportsDdlTransactions there really is no reasonable assumption that migrations can even be rolled back (since most all of them can be assumed to modify structure).

Unfortunately, "Using the latest version of Oracle" is not a possibility. I've dived into their support forms, and done a bunch of research, in the end I just forked this project and am using that in my own maven repo.

@Nthalk Nthalk closed this Mar 23, 2016
@Nthalk Nthalk deleted the no-transactions-on-db-without-transactional-ddl branch March 23, 2016 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants