Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Snowflake - upgrade from previous 5.0.7-based PR #2274

Closed
wants to merge 2 commits into from

Conversation

brianrepko
Copy link

This PR upgrades the work from @billwanjohi on #1914 to v5.2.4.

I'm still in the process of testing it

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brianrepko
Copy link
Author

testing is complete on our side - just noticed that clean was generating the wrong SQL

@AshkanK
Copy link

AshkanK commented Jan 31, 2019

Eagerly waiting for this merge into master. Thanks for a great work @brianrepko

@a-weiss-programmer
Copy link

a-weiss-programmer commented Feb 8, 2019

Will this be merged soon? My company is looking at using this for our Snowflake environment

@billwanjohi
Copy link

billwanjohi commented Feb 13, 2019

Will this be merged soon?

Unfortunately this is unlikely, per @axelfontaine's comment on a previous pull request:

At this point we would probably need some kind of commercial agreement to account for our testing, maintenance, documentation and support costs. Please get in touch if your company is willing to explore options.

The PR itself is useful as an advertisement to others of a snowflake-compatible fork, but until Flyway changes strategy, don't hold your breath about it getting merged.

@brianrepko
Copy link
Author

brianrepko commented Feb 14, 2019

Looks like I might have to upgrade this to the 6.0 beta (not sure how much has changed). However, I'm sure that someone from Snowflake could make this work / upgrade it (they do have engineers) and / or they could provide credits to test this out. It's not that difficult really with a cloud-based database. Not sure how much BoxFuse could also invest from the support contracts.

@apunhiran
Copy link

Eagerly waiting for this to be available.

@Riteshmshukla
Copy link

I work with snowflake and would like to use flyway for the versioning. how do I install flyway from this branch?

@billwanjohi
Copy link

You can make yourself a jar with the maven wrapper script in this repository. Flyway doesn't have their own instructions for this, but you can get some general guidance from this readme.

@Riteshmshukla
Copy link

thank you @billwanjohi. I will give it a try.

@mwessman
Copy link

Is there any timeline for when this might be officially supported?

@skippyabroad
Copy link

Thanks to all contributors on this. Snowflake biggest up-tick on DBEngines top 100 last month and second behind Presto for the past year.

@juliahayward
Copy link
Contributor

This PR is probably redundant now as we're working on building Snowflake support into v6.1 .

@juliahayward
Copy link
Contributor

I'm going to close this - 6.1 will be out with Snowflake support next week. Thanks to everyone who contributed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet