Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating unnecessary ResolvedMigrationComparator instances #2498

Conversation

@konopka
Copy link
Contributor

konopka commented Sep 8, 2019

Create just one instance of comparator and resuse it for each comparison

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Sep 8, 2019

CLA assistant check
All committers have signed the CLA.

@MikielAgutu MikielAgutu merged commit 4470f92 into flyway:master Sep 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@MikielAgutu MikielAgutu added this to the Flyway 6.0.3 milestone Sep 12, 2019
@konopka konopka deleted the konopka:avoid_unnecessary_resolvedmigrationcomparator_instances branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.