Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance improvement for MigrationVersion.compareTo #564

Merged
merged 1 commit into from Jul 25, 2013
Merged

performance improvement for MigrationVersion.compareTo #564

merged 1 commit into from Jul 25, 2013

Conversation

@pwielgolaski
Copy link
Contributor

@pwielgolaski pwielgolaski commented Jul 24, 2013

issue described in #563
in general moved logic of parsing to construction phase and make some reusing of
cached patterns

result of micro-brenchmarking are promising compareTo ~ 33% of old implementation where construction is faster but not so significant.

move logic of parsing to construction phase and make some reusing of
cached patterns
axelfontaine added a commit that referenced this pull request Jul 25, 2013
performance improvement for MigrationVersion.compareTo
@axelfontaine axelfontaine merged commit 8d5e81b into flyway:master Jul 25, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@pwielgolaski Could you get in touch with me via email (axel at boxfuse.com)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants