performance improvement for MigrationVersion.compareTo #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move logic of parsing to construction phase and make some reusing of cached patterns
axelfontaine
pushed a commit
that referenced
this pull request
Jul 25, 2013
performance improvement for MigrationVersion.compareTo
|
@pwielgolaski Could you get in touch with me via email (axel at boxfuse.com)? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue described in #563
in general moved logic of parsing to construction phase and make some reusing of
cached patterns
result of micro-brenchmarking are promising compareTo ~ 33% of old implementation where construction is faster but not so significant.