Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flyway#754 fix bug on quote together with comment #765

Merged
merged 1 commit into from Aug 3, 2014

Conversation

@nivolg
Copy link
Contributor

@nivolg nivolg commented May 26, 2014

This bug is common for all databases. It occurs when quote follows the comment start or precedes the comment end without whitespaces.
I add sql statement for testing all databases into common V1__Comment.sql script.
A also add V1__Comment.sql to dbsupport/oracle/comment for testing single line comment. It cannot be put into common file because mysql syntax is not supported single line comments without whitspace after --

My pull requet #764 is wrong. This is correct.

axelfontaine added a commit that referenced this pull request Aug 3, 2014
 #754 fix bug on quote together with comment
@axelfontaine axelfontaine merged commit 793f741 into flyway:master Aug 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 3, 2014

Thanks Nick! Merged. I've added you to the hall of fame (flyway 3.1 branch).

Cheers
Axel

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@nivolg Could you please get in touch with me via email? (axel at boxfuse.com) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.