flyway#754 fix bug on quote together with comment #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelfontaine
pushed a commit
that referenced
this pull request
Aug 3, 2014
#754 fix bug on quote together with comment
|
Thanks Nick! Merged. I've added you to the hall of fame (flyway 3.1 branch). Cheers |
|
@nivolg Could you please get in touch with me via email? (axel at boxfuse.com) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is common for all databases. It occurs when quote follows the comment start or precedes the comment end without whitespaces.
I add sql statement for testing all databases into common V1__Comment.sql script.
A also add V1__Comment.sql to dbsupport/oracle/comment for testing single line comment. It cannot be put into common file because mysql syntax is not supported single line comments without whitspace after --
My pull requet #764 is wrong. This is correct.