-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I fear we messed up #73
Comments
For sure this is a very hacky workaround. Actually I tried to remove that workaround before releasing the new version but somehow the app shows itself as peer which is gone after a website reload. But I can try to debug into it again... |
The PR fixes the injection isssue.
if removed it doesnt show itself anymore...well sometimes it does if you quit and reopen fast...but only once - with this code sometimes the app is creating 3 peers or more |
It was required when using my github fork, but probably not when using the original website. Thanks for finding the fix 😃👍 I will try your PR and report back... |
I have to say it seems no different if this code is remved or not and i also encountered the app showing itself sometimes with |
here it is RobinLinus/snapdrop#215 |
I tried to do that in the |
yea i see, i feel like that doesnt work at all, bacause |
Maybe this is only an issue if the app is force closed and reopened, which should be rare under real life conditions, i'll test some more, but i think removing the EDIT: yea that seems to be the case, there are no duplicates if the app is
so you can safely merge :) |
Yes, when reinstalling at the emulator it doesn't get called, but under real life conditions it's mostly fine. BTW, I really appreciate your continuous work for Snapdrop for Android - reduce the code/maintain complexity and making it better from user perspective. Thanks for your help! |
sure no problem, this was really bugging me :P |
After the recent update with the js injection right into the original snapdrop.net i often encounter the app in a state where it is just displaying the page without the js injections, which of course messes up functionality like copying.
I suspect that it may have something to do with
loadAgain
it seems somewhat hacky to me, could you explain why you implemented it and if it could be removed?This often appears when started new (
onCreate
) and i'm sometimes able to fix it by moving the app to the background and then to the foreground again (onResume
).The text was updated successfully, but these errors were encountered: