Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapdrop Shows Itself #215

Closed
Bellisario opened this issue Dec 23, 2020 · 3 comments
Closed

Snapdrop Shows Itself #215

Bellisario opened this issue Dec 23, 2020 · 3 comments

Comments

@Bellisario
Copy link
Contributor

No description provided.

@Bellisario
Copy link
Contributor Author

Problem

View the name of the peer and the other...
I opened Snapdrop in two windows and it view itself...

@Bellisario Bellisario changed the title Snapdrop Shows itselves Snapdrop Shows Itself Dec 23, 2020
@RobinLinus
Copy link
Collaborator

RobinLinus commented Dec 23, 2020

This is actually a much deeper issue. Snapdrop works correctly only in a single tab ( related to #144 ).
Once you open it in another tab the new tab overwrites the server connection of the old tab. And the old tab becomes somewhat of a zombie mode because it can call the server, but the server will send all messages addressed to its peer_id to the new tab.
Even worse: if you close the old tab, then it sends a 'goodbye' to the server, which kills the connection of the new tab because both tabs share the same peer_id.

So, the real solution here is to kill the old tab as soon as you open Snapdrop in a new tab. That requires to check if a download is going on, such that you can react accordingly.

@Bellisario
Copy link
Contributor Author

Thank you @RobinLinus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants