Fixes issue #211 - EXIF data stripped while sharing pictures

[sivasubramaniamv]

Fixes #211

Device Info:

Brand: Realme
Model: Narzo 30 5G
API Level: 33 (Android 13)

Changes Made:

1. Added ACCESS_MEDIA_LOCATION permission to the manifest
2. Requested permission in MainActivity

Resources:

Android documentation (media location permission)

The EXIF data was stripped due to privacy features implemented in the Android OS. Android devices targeting Android 10 (API level 29) and above must declare the ACCESS_MEDIA_LOCATION permission and request it during runtime.

As the permission is classified as DANGEROUS, explicit user concern is required to obtain images without redacting EXIF data.

Permission is requested when the user enters MainActivity

The image EXIF data is retained when shared from within the app and Intent (Share with - Snapdrop)

[fm-sys]

Really nice, thank you very much!

However, there are probably many users who don't care about retained EXIF data but would be afraid of granting the permission. What about making it configurable in the settings?

[sivasubramaniamv]

I tried to make it configurable in the settings, but there are a few challenges.

As you can see in the picture, it is a switch preference that is disabled by default. When the user clicks on it, the permission prompt appears. Depending on the user's choice to grant or deny the permission, the switch UI state should change.

Let's say that the user granted permission and uses the app for some time. They come back to the app settings and click on the "Retain location metadata" preference again, expecting that the location data will be removed in transfers thereafter. But that's not how it works right? It is a permission and not a feature that we can enable or disable anytime within the application.

I'm unsure if there is a programmatic way to disable the permissions that were granted to our app by the user. Even if we can manage to do so, the Android OS will prevent the permission dialog from appearing more than two times for specific permission.

Can you propose a feasible way of making it configurable in the settings?

[fm-sys]

Your screenshot looks really good 👍

Maybe add a hint to the summary to make clear it is a one-way-toogle.

Something like this:

Some media files might contain location data, which are stripped by default. Grant permission to include full metadata.

We could hide / grey out the toggle as soon as permission is granted.

[sivasubramaniamv]

Now when the user grants permission or denies it two times (denies it permanently) the preference is disabled.

[fm-sys]

LGTM, thank you!

(I've pushed some changes to match with our code style)