Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release for Apple Silicon #85

Open
fmaclen opened this issue Sep 18, 2022 · 2 comments
Open

Add release for Apple Silicon #85

fmaclen opened this issue Sep 18, 2022 · 2 comments
Labels
Electron Involves Electron's code macOS Affects the app running on macOS

Comments

@fmaclen
Copy link
Owner

fmaclen commented Sep 18, 2022

No description provided.

@fmaclen fmaclen added macOS Affects the app running on macOS Electron Involves Electron's code labels Sep 18, 2022
fmaclen added a commit that referenced this issue Sep 18, 2022
@fmaclen
chore: build release for Apple silicon
8b118af 
Fixes #85
@github-actions

This comment was marked as outdated.

Sign in to view
@fmaclen
Copy link
Owner Author

fmaclen commented Sep 18, 2022 •
edited
Loading 

# electron-builder.yml

mac:
  target:
    - target: dmg
      arch:
        - x64
        - arm64

This configuration didn't work when building the app on Github Actions, my very uninformed guess is because in release.yml we specify macos-latest as the matrix.os strategy and that only applies to the x86 version.

Reopening it because it's not fixed.

Note that the x86 version works well through Rosetta on Macs with Apple silicon.

@fmaclen fmaclen reopened this Sep 18, 2022
@fmaclen fmaclen removed the released label Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Electron Involves Electron's code macOS Affects the app running on macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmaclen