Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Run" button should be disabled if the server is disconnected, no model is chosen or has no prompt #21

Closed
fmaclen opened this issue Apr 11, 2024 · 1 comment · Fixed by #99
Closed

"Run" button should be disabled if the server is disconnected, no model is chosen or has no prompt #21

fmaclen opened this issue Apr 11, 2024 · 1 comment · Fixed by #99
Assignees
@GregoMac1
Labels
enhancement New feature or request released

Comments

@fmaclen
Copy link
Owner

fmaclen commented Apr 11, 2024 •
edited
Loading

  • The existing button is located in sessions/[id]/+page.svelte
  • Right now it's only disabled if it has !prompt
  • The only server check we do is in the Settings view and the server status not globally available.
  • This is the current Typescript definition of Settings.
  • We could probably save the server status to the settingsStore so we can access it from the Sessions view.
  • Currently, we only check the status of the server whenever ollamaServer changes.
    • That means that if the server went offline after starting a new session the status would still appear as online.
    • This is not ideal because submitting the form to an offline server would cause an error but we should handle that behavior in Reset session when an error occurs #49
  • Should add a new test for this behavior in sessions.test.ts
@fmaclen fmaclen added the enhancement New feature or request label Apr 11, 2024
@fmaclen fmaclen changed the title "New session" and "Send" buttons should be disabled if the server is disconnected or no model is chosen "Run" button should be disabled if the server is disconnected, no model is chosen or has no prompt Jul 8, 2024
@fmaclen fmaclen mentioned this issue Jul 10, 2024
Closed
@GregoMac1 GregoMac1 self-assigned this Jul 18, 2024
@GregoMac1 GregoMac1 linked a pull request Jul 18, 2024 that will close this issue
fix: Disable Run button if server is disconnected or no model is chosen #99
Merged
@GregoMac1 GregoMac1 mentioned this issue Jul 20, 2024
Merged
fmaclen added a commit that referenced this issue Jul 29, 2024
@GregoMac1 @fmaclen
fix: Disable Run button if server is disconnected or no model is chos…
a6be195 
…en (#99)

Closes #21 
Closes #80 
Closes #105

---------

Co-authored-by: Fernando Maclen <fmaclen@gmail.com>
@fmaclen
Copy link
Owner Author

fmaclen commented Jul 29, 2024

🎉 This issue has been resolved in version 0.7.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoMac1 GregoMac1

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Disable Run button if server is disconnected or no model is chosen fmaclen/hollama
2 participants
@fmaclen @GregoMac1