Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRF 3.10 compatibility #11

Merged
merged 1 commit into from
Feb 8, 2020
Merged

DRF 3.10 compatibility #11

merged 1 commit into from
Feb 8, 2020

Conversation

vittorio
Copy link
Contributor

@vittorio vittorio commented Feb 8, 2020

In DRF 3.8 they have announced detail_route and list_route deprecation and it has been removed since 3.10

https://www.django-rest-framework.org/community/3.8-announcement/#deprecations

@coveralls
Copy link

coveralls commented Feb 8, 2020 •
edited

Pull Request Test Coverage Report for Build 43

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.714%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 138
Relevant Lines: 161
💛 - Coveralls

@vittorio vittorio requested a review from fmarco February 8, 2020 15:32
@vittorio
Copy link
Contributor Author

vittorio commented Feb 8, 2020

That will fix #8

@fmarco
Copy link
Owner

fmarco commented Feb 8, 2020

@vittorio LGTM, thank you!

@fmarco fmarco merged commit f616ea7 into fmarco:master Feb 8, 2020
@fmarco fmarco mentioned this pull request Feb 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarco fmarco fmarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vittorio @coveralls @fmarco