Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invitation views settings #15

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

artemdumanov
Copy link

No description provided.

@coveralls
Copy link

coveralls commented May 17, 2020

Pull Request Test Coverage Report for Build 50

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 86.061%

Totals Coverage Status
Change from base Build 49: 0.3%
Covered Lines: 142
Relevant Lines: 165

💛 - Coveralls

@fmarco fmarco self-requested a review November 18, 2020 08:16
accept_invitation = import_callable(
getattr(
settings,
'INVITATION_ACCEPT_INVATION',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a typo

from .utils import import_callable
from django.conf import settings

InvitationViewSet = import_callable(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some doc info about these changes?

@fmarco
Copy link
Owner

fmarco commented Nov 18, 2020

@artemdumanov sorry i handle now this pr, i made a review (after that could you please also squash the commits?)

Delete print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants