bug in netcdf time (#20)

fmaussion · Oct 23, 2016 · 151e4af · 151e4af
1 parent 0a7c464
commit 151e4af
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/docs/whats-new.rst b/docs/whats-new.rst
@@ -2,9 +2,18 @@ What's New
 ==========
 
 
-v0.1.0 (22 October 2016)
+v0.1.1 (Unreleased)
 -------------------
 
+Bug fixes
+~~~~~~~~~
+
+- GeoNetCDF files without time variable should now open without error
+
+
+v0.1.0 (22 October 2016)
+------------------------
+
 Big refactoring (:pull:`15`), partly backwards incompatible (mostly renaming).
 Improved xarray accessors, WRF tools, merged `Cleo`_ into the codebase,
 added a first draft of documentation.

diff --git a/salem/sio.py b/salem/sio.py
@@ -333,8 +333,13 @@ def netcdf_time(ncobj, monthbegin=False):
     import pandas as pd
 
     time = None
-    vt = utils.str_in_list(ncobj.variables.keys(),
-                           utils.valid_names['time_var'])[0]
+    try:
+        vt = utils.str_in_list(ncobj.variables.keys(),
+                               utils.valid_names['time_var'])[0]
+    except IndexError:
+        # no time variable
+        return None
+
     if hasattr(ncobj, 'TITLE') and 'GEOGRID' in ncobj.TITLE:
         # geogrid file
         pass

diff --git a/salem/tests/test_misc.py b/salem/tests/test_misc.py
@@ -139,6 +139,17 @@ def test_read_to_grid(self):
                         df2.geometry[0].exterior.coords)
 
 
+    @requires_xarray
+    def test_notimevar(self):
+
+        import xarray as xr
+        da = xr.DataArray(np.arange(12).reshape(3, 4), dims=['lat', 'lon'])
+        ds = da.to_dataset('var')
+
+        t = sio.netcdf_time(ds)
+        assert t is None
+
+
 class TestColors(unittest.TestCase):
 
     @requires_matplotlib