Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The lexer should not report any errors #13

Closed
7 tasks done
fmease opened this issue Sep 29, 2020 · 0 comments · Fixed by #161
Closed
7 tasks done

The lexer should not report any errors #13

fmease opened this issue Sep 29, 2020 · 0 comments · Fixed by #161
Labels
T-enhancement Type: Enhancement

Comments

@fmease
Copy link
Owner

fmease commented Sep 29, 2020 •
edited
Loading

Instead, special tokens should be emitted which the parser then uses to report errors.

Don't return early on

  • invalid tokens (via 61bfeba)
  • unterminated text literals (also via above commit)
  • number literals "out of range" (relevant until we removed number literal suffixes) (via c774b0d)
  • trailing dashes in identifiers
  • consecutive primes in number literals
  • trailing primes in number literals
  • unbalanced brackets
@fmease fmease mentioned this issue Oct 5, 2020
Open
13 tasks
fmease added a commit that referenced this issue Oct 6, 2020
@fmease
Start moving error handling from lexer to parser
61bfeba 
There are still large blockers to fully move the error checking in preparation for
a smarter parser (#22). Mainly `crate::lexer::token::TokenData` which contains parsed
data and bracket balancing code.

This works towards closing issue #13.
@fmease fmease added T-enhancement Type: Enhancement and removed T-enhancement labels Dec 14, 2020
@fmease fmease changed the title Lexer should not report any errors The lexer should not report any errors Aug 14, 2022
@fmease fmease mentioned this issue Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-enhancement Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not report any errors in the lexer and do not bail out early fmease/lushui
1 participant
@fmease