Skip to content
This repository has been archived by the owner on Apr 11, 2018. It is now read-only.

Fix minor errors and typos #110

Merged
merged 2 commits into from Nov 17, 2016
Merged

Fix minor errors and typos #110

merged 2 commits into from Nov 17, 2016

Conversation

pmmitkov
Copy link
Contributor

No description provided.

georgyangelov
georgyangelov reviewed Nov 15, 2016
View reviewed changes
lectures/10-rspec-require.slim
@@ -269,7 +269,7 @@
= slide 'С mock-ване' do
example:
it 'increases the like counter of the game' do
game = double
game = double(:likes => 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добро наблюдение! :)

Промени го, така че да използва новия синтаксис за хешове. И изпусни скобите тук, за прегледност

@georgyangelov
Copy link
Contributor

Благодаря ти за корекциите. Оставих един коментар - оправи го и може да го мърджнем.

ПП. Прави следващи PR-и от твой бранч, не директно от master. Има инструкции тук: https://github.com/fmi/ruby-course-guides/blob/master/pull_requests.md

@pmmitkov
Copy link
Contributor Author

@georgyangelov Мерси за коментара, Оправих примера в последния commit и мисля, че сега е ОК. Не знаех за guide-a и в бъдеще ще правя PR както е описано там. :)

@georgyangelov
Copy link
Contributor

Супер, мерси :)

@georgyangelov georgyangelov merged commit b387a49 into fmi:master Nov 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgyangelov georgyangelov georgyangelov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmmitkov @georgyangelov