Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

|a, e| is discouraged in fmi-ruby course. #1

Merged
merged 3 commits into from Oct 14, 2012
Merged

Conversation

comco
Copy link

@comco comco commented Oct 13, 2012

One of the comments of my solution is that we shouldn't use |a,e| instead |accumulator, element|. In general, one-letter variable names are bad.

@mitio
Copy link
Member

mitio commented Oct 13, 2012

Even more — whenever possible, attempt to find a proper contextual naming of a variable and avoid using a generic one, such as accumulator or element.

Could you make that clear in the pull request too?

/cc @skanev

skanev added a commit that referenced this pull request Oct 14, 2012
|a, e| is discouraged in fmi-ruby course.
@skanev skanev merged commit 2e9c45a into fmi:master Oct 14, 2012
@skanev
Copy link
Member

skanev commented Oct 14, 2012

Макар и скромно, като за първо включване, заслужаваш бонус точка. Ето ти код: GH-COMCO-1

@comco
Copy link
Author

comco commented Oct 15, 2012

Áëàãîäàðÿ.

2012/10/14 Stefan Kanev notifications@github.com

Ìàêàð è ñêðîìíî, êàòî çà ïúðâî âêëþ÷âàíå, çàñëóæàâàø áîíóñ òî÷êà. Åòî òè
êîä: GH-COMCO-1


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-9427635.

@mitio
Copy link
Member

mitio commented Oct 16, 2012

Нещо не се чете това, което си написал, но се надявам, че е "Благодаря." :)

@comco
Copy link
Author

comco commented Oct 17, 2012

Да, Благодаря.
PS. Бях отговорил на коментара директно по мейл :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants