Skip to content

Commit

Permalink
Adding new stage for the CI workflow: running pylint on code base (#101)
Browse files Browse the repository at this point in the history
No changes to functionality, only adding pylint code quality checks to
the CI build. This closes #99
  • Loading branch information
fmilthaler committed Jul 15, 2023
1 parent 99d9ca9 commit 40bef5b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: actions/checkout@v3

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -35,4 +35,9 @@ jobs:
python -m pip install .[test]
- name: Run tests
run: make test
run: make test

- name: Analysing the code with pylint
if: ${{ matrix.python-version }} == '3.10'
run: |
pylint --fail-under=9 $(git ls-files '*.py')
1 change: 0 additions & 1 deletion requirements_dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
black==23.1.0
pylint
mypy
isort
jupyter
Expand Down
3 changes: 2 additions & 1 deletion requirements_test.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pytest>=7.3.2
pytest>=7.3.2
pylint

0 comments on commit 40bef5b

Please sign in to comment.