New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vo2_max() and workload column option #6
Comments
Hey Scott! Thanks a lot for trying it out! Have you tried setting the I am going to update pkgdown, I hadn't noticed that before! Thank you! |
Hey Felipe, Thanks for the quick reply. Unfortunately, setting the I suppose if the perform_max <- function(.data,
vo2_column = "VO2",
vo2_relative_column = NULL,
heart_rate_column = NULL,
rer_column = NULL,
work_rate_column = NULL,
average_method = c("bin", "rolling"),
average_length = 30,
plot = TRUE,
verbose = TRUE) {
if (!is.null(work_rate_column))
if (! work_rate_column %in% colnames(.data))
stop(glue::glue("It looks like the column {work_rate_column} does not exist."),
call. = FALSE)
out <- dplyr::tibble(POpeak = ifelse(
is.null(work_rate_column),
as.integer(max(data_normalized[["work_rate"]])),
as.interger(max(data_normalized[[work_rate_column]]))
))
} Might this work? Thanks again, Felipe. You'll be pleased to know |
Oh, I see what the problem is.. I initially had an argument to specify the work rate column in It is great to hear that you are using it in your thesis!! If you have any suggestions, feel free to open a discussion in the Discussion tab! I am always looking for ways to improve the package. |
Hey Scott, I have just created a PR: #7 Could you give it a try? You can install it with: |
Works a treat, Felipe. Thanks 🙌 |
Thanks a lot for reporting it, Scott! |
Hi Felipe,
It's me again... haha.
I was just trialing the new
vo2_max()
function and was wondering whether you would consider adding an option to use a pre-defined workload column? Thework_rate_magic
option is fantastic but I already have workrate column produced by the gas analyser.p.s. your GitHub links on your packagedown site are leading to a 404 page. I think there's an
M
missing from your GitHub account name 🤦♂️Thanks,
Scott
The text was updated successfully, but these errors were encountered: