Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt::to_string/compilation doesn't work with a null string_view #3241

Closed
DenisYaroshevskiy opened this issue Dec 22, 2022 · 3 comments
Closed

fmt::to_string/compilation doesn't work with a null string_view #3241

DenisYaroshevskiy opened this issue Dec 22, 2022 · 3 comments

Comments

@DenisYaroshevskiy
Copy link

At the moment you can't fmt a default constructed string_view: https://godbolt.org/z/ddzYqYE99
@vitaut
Copy link
Contributor

vitaut commented Dec 22, 2022

Specifically, this is about fmt::to_string.

@DenisYaroshevskiy
Copy link
Author

I don't think so https://godbolt.org/z/Y6e4oPdPx

@vitaut vitaut changed the title Memcping a nullptr is a ub fmt::to_string/compilation doesn't work with a null string_view Dec 22, 2022
@DenisYaroshevskiy
Copy link
Author

FYI: this is how libc++ does this: https://github.com/llvm/llvm-project/blob/ce5ef7d1d5dc632a1ff35110821a44978e004e5f/libcxx/include/__algorithm/copy.h#L60

phprus added a commit to phprus/fmt that referenced this issue Dec 23, 2022
@phprus
Fix for issue fmtlib#3241
2a0c98c 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus phprus mentioned this issue Dec 23, 2022
Merged
vitaut pushed a commit that referenced this issue Dec 23, 2022
@phprus @vitaut
Fix for issue #3241
e004f1d 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @DenisYaroshevskiy