Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some clang-tidy warnings #1627

Closed
wants to merge 2 commits into from
Closed

Fixed some clang-tidy warnings #1627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3934e8c
Fix clang warning about explicit ctor
gabime Apr 10, 2020
09a90de
Fixed clang tidy warning -multiple declarations in a single statement…
gabime Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/format.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct sprintf_specs {
bool alt : 1;

template <typename Char>
constexpr sprintf_specs(basic_format_specs<Char> specs)
constexpr explicit sprintf_specs(basic_format_specs<Char> specs)
: precision(specs.precision), type(specs.type), alt(specs.alt) {}

constexpr bool has_precision() const { return precision >= 0; }
Expand Down Expand Up @@ -81,7 +81,8 @@ char* sprintf_format(Double value, internal::buffer<char>& buf,
unsigned n = internal::to_unsigned(result);
if (n < buf.capacity()) {
// Find the decimal point.
auto p = buf.data(), end = p + n;
auto *p = buf.data();
auto *end = p + n;
if (*p == '+' || *p == '-') ++p;
if (specs.type != 'a' && specs.type != 'A') {
while (p < end && *p >= '0' && *p <= '9') ++p;
Expand Down