Exclude std::abort from compilation when compiling CUDA with Clang #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
May 3, 2020
| @@ -47,7 +48,11 @@ namespace internal { | |||
|
|
|||
| FMT_FUNC void assert_fail(const char* file, int line, const char* message) { | |||
| print(stderr, "{}:{}: assertion failed: {}", file, line, message); | |||
| #if defined(__clang__) && defined(__CUDA__) && defined(__CUDA_ARCH__) | |||
| std::terminate(); | |||
There was a problem hiding this comment.
I think we can use std::terminate unconditionally but please add a short comment clarifying that it was chosen instead of abort because of CUDA.
vitaut
reviewed
May 3, 2020
include/fmt/format-inl.h
Outdated
| std::terminate(); | ||
| #else | ||
| std::abort(); | ||
| #endif |
There was a problem hiding this comment.
My bad. I Tested the wrong branch locally!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes
std::abortfor device code only. Fixes #1659.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.