Fix a conversion warning with Clang10 on Windows #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jul 2, 2020
include/fmt/format.h
Outdated
| @@ -566,7 +566,7 @@ template <typename U> | |||
| void buffer<T>::append(const U* begin, const U* end) { | |||
| size_t new_size = size_ + to_unsigned(end - begin); | |||
| reserve(new_size); | |||
| std::uninitialized_copy(begin, end, make_checked(ptr_, capacity_) + size_); | |||
| std::uninitialized_copy(begin, end, make_checked(ptr_ + size_, capacity_)); | |||
There was a problem hiding this comment.
Thanks for the PR. I think you also need to subtract size_ from capacity_.
There was a problem hiding this comment.
Will do, but why do all the test pass? :)
There was a problem hiding this comment.
Because we don't write over capacity. The whole checked iterator machinery in MSVC is completely useless and is here mostly to avoid warnings but let's provide correct bounds anyway.
0x8000-0000
force-pushed
the
fix-conversion-warning
branch
from
8f7bdbf
to
cdbbe00
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1747
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.