Extending fmt::join to support C++20-only ranges. #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brevzin
force-pushed
the
cpp20-only-ranges
branch
from
df003a7
to
3e80e25
Compare
|
Thanks for the PR. Looks good but please apply clang-format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++20 Ranges model means that you can have a type which is a C++20 range but not a C++17 range (an example of such is
views::joinon a range of prvalue ranges, orviews::iotaif the underlying type doesn't satisfyincrementable).We just have to use
std::iter_value_t<It>instead of going throughstd::iterator_traitsdirectly (bonus, it's shorter, and notypename) and we have to not use*it++and instead manually do*itand then++it, since C++20 input iterators are allowed to haveit++bevoid.