Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format unique_ptr with custom deleter #3177

Merged
merged 2 commits into from Nov 14, 2022
Merged

Format unique_ptr with custom deleter #3177

merged 2 commits into from Nov 14, 2022

Conversation

hmbj
Copy link
Contributor

@hmbj hmbj commented Nov 12, 2022

Added deleter type to fmt::ptr unique_ptr overload. Deleter type is part of the unique_ptr type.

@hmbj
Format unique_ptr with custom deleter
0a4dd1e 
Added deleter type to fmt::ptr unique_ptr overload. Deleter type is
part of the unique_ptr type.
vitaut
vitaut requested changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please apply clang-format.

@hmbj
Copy link
Contributor Author

hmbj commented Nov 13, 2022

LGTM but please apply clang-format.

Cool. Ran clang-format on changed files.

@vitaut vitaut merged commit 7df30f9 into fmtlib:master Nov 14, 2022
@vitaut
Copy link
Contributor

vitaut commented Nov 14, 2022

Thanks!

@hmbj hmbj deleted the format-unique_ptr-with-custom-deleter branch November 14, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmbj @vitaut