Fix warnings under MSVC #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Mar 14, 2018
| @@ -1452,7 +1452,7 @@ class arg_formatter_base { | |||
|
|
|||
| void operator()(const char_type *value) { | |||
| internal::handle_cstring_type_spec( | |||
| specs_.type_, cstring_spec_handler(*this, value)); | |||
| static_cast<char>(specs_.type_), cstring_spec_handler(*this, value)); | |||
There was a problem hiding this comment.
I think it would be better to make character type a template parameter of handle_cstring_type_spec instead, because otherwise an invalid type specifier can be transformed into a valid one by a narrowing cast which is undesirable.
Same in similar places below.
There was a problem hiding this comment.
Oh, you just did that, I was grepping through the code and couldn't find those casts anymore.. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #678.