Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@VERSION #340

Closed
dotherightthing opened this issue Jun 4, 2014 · 5 comments
Closed

@VERSION #340

dotherightthing opened this issue Jun 4, 2014 · 5 comments

Comments

@dotherightthing
Copy link

Hi, just a small thing - when I run this in the console:

$.ui.version

I get "@VERSION".

But what I expect (from your readme) is "1.9.2".

Is @VERSION a placeholder that is (not) being replaced during your builds?

Thanks,
Dan

@fnagel
Copy link
Owner

fnagel commented Jun 5, 2014

Yes, this placeholder should be replaced within the built process but currently there is no built process for this fork.

You should probably not use the delivered dev files of jQuery / UI but an official custom built and add only the selectmenu js and css file in addition.

@dotherightthing
Copy link
Author

Thanks Felix, I'm using Bower to manage my plugins and dependencies, so it's easier to pull the selectmenu code in this way too. Wouldn't it be risky to use a newer/different version of jQuery UI than what you've tested your plugin with anyway?

@fnagel
Copy link
Owner

fnagel commented Jun 5, 2014

Fell free to send a PR with a built script and even Bower support.

You should not use a newer version of jQuery / UI with this version of Selectmenu, right. I wanted to say it's recommended to use a official built from jqueryui.com itself rather than the files in this repo.

@fnagel
Copy link
Owner

fnagel commented Jun 27, 2014

Any feedback on this issue?

@fnagel
Copy link
Owner

fnagel commented Sep 30, 2014

Closed as no feedback was given. Please reopen if needed.

@fnagel fnagel closed this as completed Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants