refined safari webapp or cna check #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def safari_webapp_mode_or_cna? | ||
| tokens = ua.scan(/(\w+)(?=\/[\d\.]+)/).flatten | ||
| tokens.include?('Mozilla') && tokens.include?('AppleWebKit') && | ||
| (tokens.size == 2 || (tokens.size == 3 && tokens.include?('Mobile'))) |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
fnando
force-pushed
the
master
branch
4 times, most recently
from
6a50a3f
to
b7eb5eb
Compare
fnando
force-pushed
the
master
branch
2 times, most recently
from
efdcd67
to
2565ccc
Compare
fnando
force-pushed
the
master
branch
2 times, most recently
from
3e90951
to
6db807b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to be able to narrow down if requests are coming in from Apple's captive network assistant (CNA). It turns out that these UA strings are identical to the fullscreen webapp mode. I changed the method name to reflect that and attempted to make a check that is resistant to new browsers or changes in browser names. The only defining characteristic here is that it has AppleWebKit without Safari, but many UA strings satisfy this requirement and simply add additional non-Safari items. I noticed that the existing method returned incorrect results against some of the UA string in the test cases, so I updated the tests and believe I have corrected this.