added function that returns more detailed platform information #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/browser/methods/platform.rb
Outdated
|
|
||
| def platform_version | ||
| case | ||
| when linux? |
There was a problem hiding this comment.
Indent when as deep as case.
lib/browser/methods/platform.rb
Outdated
| @@ -108,5 +108,35 @@ def platform | |||
| :other | |||
| end | |||
| end | |||
|
|
|||
| #returns platform as string and additionally OS version in case of Windows | |||
There was a problem hiding this comment.
Missing space after #.
fnando
added a commit
that referenced
this pull request
Nov 20, 2014
fnando
force-pushed
the
master
branch
4 times, most recently
from
6a50a3f
to
b7eb5eb
Compare
|
Hi, Do you have a similar feature like this yet? |
fnando
force-pushed
the
master
branch
2 times, most recently
from
efdcd67
to
2565ccc
Compare
ellimist
pushed a commit
to ellimist/browser
that referenced
this pull request
Mar 15, 2017
fnando
force-pushed
the
master
branch
2 times, most recently
from
3e90951
to
6db807b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a requirement in our project that forced us to extend the platform methods with a method that returns more detailed information of platform version (especially windows). I would suggest to merge it into your repo.