Add note for using yarn if using webpacker #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mlodato517, TravisBuddy Request Identifier: d0ec44b0-f818-11ea-8f9f-a900ee46d44b |
|
Thanks for the PR Since it's "optional step for installation" |
PikachuEXE
suggested changes
Sep 16, 2020
README.md
Outdated
| If you're using `webpacker`, you may need to add the dependencies to your client with: | ||
|
|
||
| ``` | ||
| yarn add i18n-js |
There was a problem hiding this comment.
# Depends on your package manager
npm install i18n-js
# or
yarn add i18n-jsThere was a problem hiding this comment.
Okay! I chose yarn since it's what webpacker uses and you have to go through some hoops to use npm with webpacker but this sounds good!
PikachuEXE
approved these changes
Sep 17, 2020
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds a note to the README to
yarn add i18n-jsif using webpackerWhy?
I'm not actually sure if this is the right way to handle things but I followed the README for "without asset pipeline" and then got stuck because there was no
I18non the client. I was pointed to this gist and after adding thei18n-jspackage to the client, "everything worked".If this isn't the right advice, I'd be happy to help update it to whatever it needs to be and/or point users in the right direction if this is already documented elsewhere!