Support normalizing attributes even if they are not backed by database columns #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-picked. Thanks for your patch. ;) |
|
Thanks for your fast response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team needed to use this gem to normalize model attributes that were not directly backed by database columns. (Our specific use case involves several attributes handled by the attr_encrypted gem, but any attribute that's set via standard accessor methods should, in principle, be normalizable.)
This PR changes the
apply_normalizersmethod so that it will first attempt to use ActiveRecord'swrite_attributemethod, but fall back to using a standard setter method if that attempt fails.A spec was added to test this behavior.