default value for string

[kungfu-origin]

It appears sqlite only accept single quote for default string values, which requires the code below to use single quote when serializing:

        template<>
        struct statement_serializator<std::string, void> {
            using statement_type = std::string;

            template<class C>
            std::string operator()(const statement_type &c, const C &context) const {
                if(context.replace_bindable_with_question) {
                    return "?";
                } else {
                    return "'" + c + "'";
                }
            }
        };

[fnc12]

how can I reproduce the bug?

[kungfu-origin]

Try this code (with sqlite_orm 1.6):

struct Contact {
  int id = 0;
  std::string firstName;
  std::string lastName;
  std::string phone;
};

using namespace sqlite_orm;
auto storage = make_storage("/tmp/test.sqlite",
                            make_table("contacts",
                                       make_column("contact_id", &Contact::id, primary_key()),
                                       make_column("first_name", &Contact::firstName, default_value <std::string> ("")),
                                       make_column("last_name", &Contact::lastName, default_value <std::string> ("")),
                                       make_column("phone", &Contact::phone)));
storage.sync_schema();

The error would be:

default value of column [first_name] is not constant in "CREATE TABLE 'contacts' ( 'contact_id' INTEGER PRIMARY KEY NOT NULL , 'first_name' TEXT DEFAULT ("") NOT NULL , 'last_name' TEXT DEFAULT ("") NOT NULL

[fnc12]

@TaurusAI does it reproduce in dev branch?

[kungfu-origin]

@TaurusAI does it reproduce in dev branch?

yes

[fnc12]

@TaurusAI ok thanks. I shall fix it today

[fnc12]

the fix is on its way #642

[kungfu-origin]

the fix is on its way #642

Great, thanks!

[fnc12]

@TaurusAI merged in dev branch. Please check it out

[fnc12]

@TaurusAI does everything work?

[kungfu-origin]

@TaurusAI does everything work?

Yes, dev is working now, thanks!

Looking forward to 1.7 release.