New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bioschemas by proxying Wikidata content (making Google bots happy) #1478
Conversation
@fnielsen, yes, I see the flake issues. I will fix those, when you told me you like the idea. |
Should |
No, the intention is only JSON.
Yeah, I guess that would be more correct: only return JSON when asked for JSON, return 415 for any other media type. So, go ahead? |
Okay, I will assume this is a go ahead. |
b144738
to
45a0bc5
Compare
I also took the liberty of replacing java-style conditionals and names with python-style code
- shortened lines - missing whitespace - undefined inchi variable - unused variable
815b66c
to
3ef5ba6
Compare
Current tests:
These test normal behavior for 6 Bioschemas profiles, prefixing, and list/string variation. |
Article on Bioschemas: https://scholia.toolforge.org/work/Q108345828 |
This has been reverted. It was an accidental merge and there are at least two styling errors. |
Where is the issue for this PR? |
Basically, this is the issue: #1189 |
Can you give more detail, please? When I run
|
@fnielsen, this is now a finished patch, but if you have additional ideas, plz let me know (if not, please do merge in).
The new design solve the problem of the
robots.txt
blocking calls and limiting the SEO indexing of Scholia pages:/$qid/bioschemas
which returns JSONbase.html
uses this new call instead of a call to wikidata.org (with therobots.txt
problem)The extra call is only made when the aspect template has an
id=bioschemas
holder.Possibly future optimization:
property_for_q()
calls are replaced by a singleproperties_for_q(q, {"P235": "key1", "Pxx": "key2", ...})