adds Twitter accounts and the hashtag (implements #1045) #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
egonw
commented
Feb 18, 2020
egonw
commented
- to pages that already showed some info
- and details are now shown for events and event series too
- Twitter account
- hashtag, which points to the wmflabs hashtags-hub service
|
The current implementation does not indicate that the handle is for Twitter - perhaps add a Twitter logo (perhaps this t or this bird). |
egonw
added
the
needs revision
|
Logo added:
|
egonw
removed
the
needs revision
|
Looks good to me now, also for hashtags. |
fnielsen
reviewed
Feb 24, 2020
scholia/app/templates/base.html
Outdated
|
|
||
| try { | ||
| var twitterAccount = item.claims.P2002[0].mainsnak.datavalue.value; | ||
| $( '#details' ).append( '<a href="https://twitter.com/' + twitterAccount + '">@' + twitterAccount + '</a> '); |
There was a problem hiding this comment.
I wonder if we might want a escape here, - just in case? I see that the above fullTextUrl does not have one...
There was a problem hiding this comment.
Escape of what? I think the Twitter account name is meant to give valid URLs.
|
I have begone to work a bit on the code here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.